feat: add string.isbn keyword for ISBN validation#1622
Open
Ojoxux wants to merge 1 commit into
Open
Conversation
Ojoxux
changed the title
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — adds string.isbn as a built-in keyword for ISBN-10 and ISBN-13 validation with checksum verification, following the same patterns as string.creditCard.
- Add
isbnkeyword withisIsbn10/isIsbn13checksum helpers — validates ISBN-10 (modulo-11,Xcheck digit) and ISBN-13 (alternating 1/3 weight sum modulo-10), stripping hyphens and spaces before validation. - Register
isbninScope.moduleand namespace type — wired into thestringkeyword set alongsidecreditCard,email, etc., withisbn: stringin the$namespace type. - Add unit tests for valid/invalid ISBNs — covers valid ISBN-10, ISBN-13, hyphen/space separators,
Xcheck digit, invalid checksums, lowercasex, wrong length, and non-digit input. - Add
string.isbnentry to integrationallConfig— includes the new keyword in the configuration test fixture.
DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the precedent set by
string.creditCard, this PR introducesstring.isbnas a built-in validator.I've encountered the need for this in my own projects before, where I ended up relying on custom validation.
Validating ISBNs requires more than a simple format check, since ISBN-10 and ISBN-13 use distinct checksum algorithms:
Xas a valid check digit.As a result, rolling a custom implementation with
narrowcan be easy to get subtly wrong.Behavior:
xas a check digitExamples:
"978-4-87311-873-4""4-87311-873-5""020530902X""9784873118735""020530902x"Implementation notes:
ark/type/keywords/string.tsrootSchema({ domain: "string", predicate: ... })Scope.module$typeTest plan
x, wrong length, and non-digit input are rejectedpnpm prCheckspasses